Skip to content

musl: 1.2.3 -> 1.2.5#328072

Closed
AndersonTorres wants to merge 6 commits intoNixOS:stagingfrom
atorres1985-contrib:musl-staging
Closed

musl: 1.2.3 -> 1.2.5#328072
AndersonTorres wants to merge 6 commits intoNixOS:stagingfrom
atorres1985-contrib:musl-staging

Conversation

@AndersonTorres
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@AndersonTorres
Copy link
Member Author

@ofborg build pkgsMusl.emacs-nox

@ofborg ofborg bot requested a review from thoughtpolice July 18, 2024 04:48
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Jul 18, 2024
@AndersonTorres
Copy link
Member Author

Since it didn't hit the red lights, I will reopen on Master.

@AndersonTorres AndersonTorres mentioned this pull request Jul 19, 2024
13 tasks
@AndersonTorres
Copy link
Member Author

Reopening to investigate failures on Master.

Maybe fetchers are buggy?

Since theey is not active in a long span of time.

Also, add AndersonTorres.
Well, let's go:

- The sources were detached to a separated file, so that we can track them more
  easily.
  - Indeed some files came from Alpine Linux aports repo, however they borrowed
    from NetBSD; ideally we should pick them from their origins.
- The sources are treated as packages, with pname, version and src well-defined.

- The usage of null as default is too error-prone, as demonstrated by an old
  Emacs refactor we did.
  - I have grepped the Nixpkgs and I have not found references that nullified
    linuxHeaders.
- finalAttrs design pattern
- SRI hashes
- Use `output*` variables
- strictDeps
- env vars inside env
- Remove comments from Bash code
  - Bash is to assembly as Nix is to Haskell.
    Bash is plumbing, and comments inside it has few to no value; indeed they
    have negative value, given that they are no-ops *and* cause mass rebuilds.
  - A more or less elegant solution employed by our Emacs expression is to
    concatenate strings.
- use pushd/popd instead of subshell
- passthru
- meta:
  - get rid of nested with
  - longDescription

Phew!
@AndersonTorres AndersonTorres deleted the musl-staging branch July 22, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants